Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Provide the browser notification for events #268

Merged
merged 2 commits into from
Dec 18, 2021
Merged

Provide the browser notification for events #268

merged 2 commits into from
Dec 18, 2021

Conversation

noahingh
Copy link
Member

@noahingh noahingh commented Dec 18, 2021

Test List

  • Deployment event - Notify when the deployment is created or updated
  • Review event - Notify when the review is approved or rejected

Screen shot

Figure) Deployment event

스크린샷 2021-12-18 오후 3 19 51

Figure) Review event

image

image

@noahingh noahingh added the component: ui This issue or pull request is related to the feature of the UI-side label Dec 18, 2021
@noahingh noahingh added this to the v0.5 milestone Dec 18, 2021
@noahingh noahingh linked an issue Dec 18, 2021 that may be closed by this pull request
@noahingh noahingh marked this pull request as ready for review December 18, 2021 06:38
Copy link
Member Author

@noahingh noahingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the bug of handleDeploymentEvent.

Comment on lines -141 to -142
// Handling the event when the owner is same.
if (event.deployment?.deployer?.id !== user.id) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the condition to display all deployments even though others are triggered.

@noahingh noahingh merged commit 710dd74 into main Dec 18, 2021
@noahingh noahingh deleted the browser-noti branch December 18, 2021 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ui This issue or pull request is related to the feature of the UI-side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide the browser notification
1 participant