This repository was archived by the owner on May 30, 2024. It is now read-only.
Add a new feature auto unlock #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahingh
added
component: server
noahingh
commented
Oct 17, 2021
Comment on lines
+23
to
+32
| ls, err := i.ListExpiredLocksLessThanTime(ctx, t) | ||
| if err != nil { | ||
| i.log.Error("It has failed to read expired locks.", zap.Error(err)) | ||
| continue | ||
| } | ||
|
|
||
| for _, l := range ls { | ||
| i.DeleteLock(ctx, l) | ||
| i.log.Debug("Delete the expired lock.", zap.Int("id", l.ID)) | ||
| } |
There was a problem hiding this comment.
Delete locks that are less than the time.
noahingh
changed the title
noahingh
force-pushed
the
auto-expired-lock
branch
from
439db83 to
00b4076
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The worker deletes expired locks periodically in the background.
In UI, users could set up the auto-unlock by the date picker like the following. users do not take care of unlocking after occupying the envrionment.