This repository was archived by the owner on May 30, 2024. It is now read-only.
Change to select reviewers into static reviewers #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahingh
commented
Nov 4, 2021
Comment on lines
+48
to
+61
| i.log.Debug("Save the deployment to wait reviews.") | ||
| d, err = i.Store.CreateDeployment(ctx, d) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| for _, rvr := range env.Review.Reviewers { | ||
| i.log.Debug(fmt.Sprintf("Request a review to %s.", rvr)) | ||
| if _, err := i.requestReviewByLogin(ctx, d, rvr); err != nil { | ||
| i.log.Error("Failed to request the review.", zap.Error(err)) | ||
| } | ||
| } | ||
|
|
||
| return d, nil |
There was a problem hiding this comment.
If the review is enabled, Gitploy requests reviews to users.
Comment on lines
+101
to
+115
| rvs, _ := i.ListReviews(ctx, d) | ||
|
|
||
| for _, r := range rvs { | ||
| if r.Status == review.StatusRejected { | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| approved := 0 | ||
| for _, a := range as { | ||
| if a.Status == approval.StatusApproved { | ||
| approved = approved + 1 | ||
| for _, r := range rvs { | ||
| if r.Status == review.StatusApproved { | ||
| return true | ||
| } | ||
| } | ||
|
|
||
| return approved >= d.RequiredApprovalCount | ||
| return false |
There was a problem hiding this comment.
If there is a rejection, it blocks to deploy to GitHub. It needs at least one approval to deploy.
noahingh
added
component: server
This was referenced Nov 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: