This repository was archived by the owner on May 30, 2024. It is now read-only.
Add a new feature to configure windows freezing deployment #283
+242
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahingh
added
the
component: server
noahingh
force-pushed
the
freeze-window
branch
from
e9d6c6c to
bb83761
Compare
noahingh
force-pushed
the
freeze-window
branch
from
bb83761 to
784214f
Compare
noahingh
commented
Dec 26, 2021
| return false, e.NewErrorWithMessage(e.ErrorCodeEntityUnprocessable, "The ref is not matched with 'deployable_ref'.", nil) | ||
| func (i *Interactor) isDeployable(ctx context.Context, u *ent.User, r *ent.Repo, d *ent.Deployment, env *extent.Env) error { | ||
| // Skip verifications for roll back. | ||
| if !d.IsRollback { |
There was a problem hiding this comment.
Add a condition to skip verifications works only for deployment.
| return err | ||
| } | ||
|
|
||
| if freezed, err := env.IsFreezed(time.Now().UTC()); freezed { |
There was a problem hiding this comment.
Verify the time is in the deploy freeze window or not.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#269