This repository was archived by the owner on May 30, 2024. It is now read-only.
Create Activities page to display all deployments in one place #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahingh
added
component: ui
noahingh
commented
Mar 13, 2022
| @@ -157,7 +157,7 @@ export const searchDeployments = async (statuses: DeploymentStatusEnum[], owned: | |||
| }) | |||
|
|
|||
| const fromParam = (from)? `from=${from.toISOString()}` : "" | |||
| const toParam = (to)? `&to=to.toISOString()` : "" | |||
| const toParam = (to)? `&to=${to.toISOString()}` : "" | |||
noahingh
force-pushed
the
activity-log-ui
branch
from
6d4e825 to
fcfe4a1
Compare
noahingh
commented
Apr 10, 2022
Comment on lines
+10
to
+11
| initialValues?: SearchActivitiesValues | ||
| onClickSearch(values: SearchActivitiesValues): void |
There was a problem hiding this comment.
It defines only the initial value and action for clicking the search button as a property of the component.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
The API server has to support a query parameter for the
productionto make the production switch work.