Skip to content

Commit e1a8ab1

Browse files
Prep Firefox for mv3 (#191)
* Prep Firefox for mv3 * Update README.md Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
1 parent 83e7473 commit e1a8ab1

File tree

3 files changed

+14
-22
lines changed

3 files changed

+14
-22
lines changed

.github/workflows/submit.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,11 @@ jobs:
4848
run: pnpm plasmo build --target=chrome-mv3
4949
- name: Build the extension (Firefox)
5050
run: |
51-
./scripts/firefox-mv2.sh
52-
pnpm plasmo build --target=firefox-mv2
51+
pnpm plasmo build --target=firefox-mv3
5352
- name: Package the extension into zip artifacts
5453
run: |
5554
pnpm package --target=chrome-mv3
56-
pnpm package --target=firefox-mv2
55+
pnpm package --target=firefox-mv3
5756
- name: Browser Platform Publish (staging)
5857
uses: PlasmoHQ/bpp@v3
5958
if: env.CHANNEL == 'staging'
@@ -69,4 +68,4 @@ jobs:
6968
keys: ${{ secrets.SUBMIT_KEYS_PRODUCTION }}
7069
verbose: true
7170
chrome-file: build/chrome-mv3-prod.zip
72-
firefox-file: build/firefox-mv2-prod.zip
71+
firefox-file: build/firefox-mv3-prod.zip

README.md

+11-15
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,8 @@ The build happens automatically when you start a workspace but if you want to bu
4040

4141
```
4242
pnpm install
43-
pnpm build --target=chrome-mv3 # or --target=firefox-mv2
44-
pnpm package --target=chrome-mv3 # or --target=firefox-mv2
45-
```
46-
47-
#### Note about `--target=firefox-mv2`
48-
49-
To generate a proper `manifest.json` file for Firefox, execute the following script first. It ensures that the manifest file is generated with MV2-compatible fields.
50-
51-
```
52-
./scripts/firefox-mv2.sh
43+
pnpm build --target=chrome-mv3 # or --target=firefox-mv3
44+
pnpm package --target=chrome-mv3 # or --target=firefox-mv3
5345
```
5446

5547
### Testing
@@ -66,17 +58,16 @@ You can test the extension without publishing to the store. Before uploading the
6658

6759
1. Open Firefox
6860
1. Go to `about:debugging#/runtime/this-firefox`
69-
1. Click Load Temporary Add-on -> Select the `firefox-mv2-prod.zip` file. Please note, that some features (like extension settings) will not work.
61+
1. Click Load Temporary Add-on -> Select the `firefox-mv3-prod.zip` file. Please note, that some features (like extension settings) will not work.
7062

7163
## Release
7264

7365
We currently publish the extension for **Chrome** and **Firefox**.
7466

7567
To release a new version, follow these steps:
7668

77-
1. Bump up the version value inside `package.json`
69+
1. Bump up the version value inside `package.json` (`yarn version --patch` or `yarn version --minor`)
7870
1. Push your changes to `main`
79-
1. Create a tag `vX.Y.Z`
8071
1. Compose a list of changes using the list of commits that were pushed since last version
8172
1. [Create a new release](https://github.com/gitpod-io/browser-extension/releases/new), listing changes:
8273

@@ -92,12 +83,17 @@ To release a new version, follow these steps:
9283
Thanks to @{EXTERNAL_CONTRIBUTOR_USERNAME} for helping! 🍊
9384
```
9485

95-
For Firefox, our [GitHub Action](https://github.com/gitpod-io/browser-extension/blob/main/.github/workflows/submit.yml) should take care of publishing for us. You can trigger a release (either staging or production) from the [workflow's tab](https://github.com/gitpod-io/browser-extension/actions/workflows/submit.yml).
86+
For Firefox:
87+
88+
1. Sign in to https://addons.mozilla.org/en-US/developers/addon/gitpod/edit with the credentials from 1Password
89+
2. Click <kbd>Upload new version</kbd>
90+
3. Upload the zip file (`firefox-mv3-prod.zip`)
91+
4. Go through the steps and submit
9692

9793
For Chrome:
9894

9995
1. Using your Google account, open the [`gitpod-browser-extension Google Group`](https://groups.google.com/g/gitpod-browser-extension)
100-
2. If you don't have access, reach out for [help in Slack](https://gitpod.slack.com/archives/C020VCB0U5A)
96+
2. If you don't have access, reach out for [help in Slack](https://gitpod.slack.com/archives/C04QC1ZMPV4)
10197
3. Once you are in the Google Group, make sure to "Switch to Gitpod" in the top navbar
10298
4. Click "Upload new package"
10399
5. Upload the zip file (`chrome-mv3-prod.zip`) and submit

scripts/firefox-mv2.sh

-3
This file was deleted.

0 commit comments

Comments
 (0)