Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep Firefox for mv3 #191

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Prep Firefox for mv3 #191

merged 2 commits into from
Apr 8, 2025

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Apr 2, 2025

Description

Support for manifest v3 in Firefox has been here for a while and so is their support for optional_host_permissions.

How to test

  • Package the extension for Firefox
pnpm build --target=firefox-mv3
pnpm package --target=firefox-mv3
  • Load it as a temporary addon in about:debugging
  • Make sure it still injects the Gitpod button on GitHub and that you can add https://bitbucket.gitpod-dev.com/repos?visibility=public as an additional domain by clicking on the cog in the extensions dropdown and choosing the "Enable Gitpod on this domain" option (this is the part checking if optional_host_permissions works properly)
image

@filiptronicek filiptronicek self-assigned this Apr 2, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the extension build and release process to support Firefox MV3 instead of MV2.

  • Updated build and packaging commands in the README for Firefox MV3.
  • Modified temporary addon file names and release instructions in the README.
  • Revised the GitHub workflow (.github/workflows/submit.yml) to build and package the extension for Firefox MV3.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
README.md Updates to commands and release instructions for Firefox MV3
.github/workflows/submit.yml Workflow updates to build and package the extension for Firefox MV3
Files not reviewed (1)
  • scripts/firefox-mv2.sh: Language not supported

Co-authored-by: Copilot <[email protected]>
@mustard-mh
Copy link
Contributor

mustard-mh commented Apr 5, 2025

Works like a charm!

GitHub BitBucket
image image

@filiptronicek filiptronicek merged commit e1a8ab1 into main Apr 8, 2025
1 of 2 checks passed
@filiptronicek filiptronicek deleted the ft/firefox-mv3 branch April 8, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants