[PVC] Workspace fails on restart with misconfigured initializer if some prior instance "failed"

[geropl]

context: https://gitpod.slack.com/archives/C047BR51GDR

especially thread: https://gitpod.slack.com/archives/C047BR51GDR/p1666257320068649

example workspaces:

1. gitpodio-gitpod-njdud87zz0n https://gitpod.io/admin/workspaces/gitpodio-gitpod-njdud87zz0n
2. gitpodio-gitpod-0crlhy9mhdk https://gitpod.io/admin/workspaces/gitpodio-gitpod-0crlhy9mhdk

example trace for 1. containing wrong initializer: https://jaeger-eu-prod.workspace-preview.gitpod-io-dev.com/trace/71c1f5f3e97f870a

Code:

1. here we set hasValidBackup to false if any prior instance failed
2. here volumeSnapshots is undefined
3. so we end up here, where we create a BackupInitializer, but without setting FromVolumeSnapshot to true and without setting VolumeSnapshot.

/cc @sagor999

[iQQBot]

here we set hasValidBackup to false if any prior instance failed

Isn't this set to true if any prior instance success? then it got the wrong instance id, and set it to volumeSnapshotId

but this instance is failed, so there is no volumeSnapshots were found

[geropl]

@iQQBot Looking at this again, you're absolutely right. Well, should be easy to fix then. Will create a PR. 👍

[sagor999]

Agreed, this seems like a bug.
Intention originally was to make sure that we do not attempt to restore from failed build (as there would be no backup\snapshot available).

[kylos101]

@geropl Removed workspace team project from this (as its shipping in server). Feel free to add back if anything else is needed?