-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[server] Restart PVC workspace from latest valid backup #14053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-gpl-14030-pvc.2 because the annotations in the pull request description changed |
👋 @geropl when testing, I recommend this at least: |
Hey @kylos101 , thx for the pointer!
|
Howdy @geropl ,
Good point! 🤦
This helps tests "run faster", sometimes they can timeout, by giving the preview environment more resources. |
FYI, it could help to put these options at the bottom of the PR description, so that every build of this PR gets them. 👍 |
FYI, I tested this PR with various scenarii that failed in the context of Gitpod's PVC prebuilds / #13991 :
(I have no idea if my workspaces/prebuilds were actually using PVC, but) doing these things worked perfectly. 🙌 |
@jankeromnes see description at the top on how to configure and check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Related Issue(s)
Fixes #14030
How to test
user_pvc
is enabled for your user in ConfigCatkubectl rollout restart deployment/server
gitpod.io/pvcFeature: "true"
is present ✔️select id, creationTime, status from d_b_workspace_instance WHERE workspaceId = ' ... ';
failed
;UPDATE d_b_workspace_instance SET status = JSON_SET(status, "$.conditions.failed", 'test') WHERE id = ' ... ';
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide