Skip to content

[ws-daemon] Remove backup limiter #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csweichel opened this issue Mar 31, 2022 · 0 comments · Fixed by #9039
Closed

[ws-daemon] Remove backup limiter #9037

csweichel opened this issue Mar 31, 2022 · 0 comments · Fixed by #9039
Labels
component: ws-daemon team: workspace Issue belongs to the Workspace team

Comments

@csweichel
Copy link
Contributor

Is your feature request related to a problem? Please describe

We're limiting the disk space users can consume using XFS. Prior to that we'd deliberately not create a backup if the workspace size got too large. The latter results in adverse behaviour, because users don't get a backup and no feedback beforehand. Their data is just lost. We should remove this behaviour.

opts = append(opts, archive.TarbalMaxSize(int64(s.config.WorkspaceSizeLimit)))

Describe the behaviour you'd like

We should always make backups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ws-daemon team: workspace Issue belongs to the Workspace team
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant