Skip to content

[ws-daemon] Remove tar file size limit #9039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2022
Merged

[ws-daemon] Remove tar file size limit #9039

merged 1 commit into from
Mar 31, 2022

Conversation

csweichel
Copy link
Contributor

Description

This PR removes the backup tarbal size limit in favour of the XFS project quota. This removes one reason why users might not get a backup.

Related Issue(s)

Fixes #9037

How to test

Fill the /workspace volume to the last byte, stop the workspace and start it again. You should get a backup.

Release Notes

Removed leftover workspace size limit which could prevent backups from being created.

@csweichel csweichel requested a review from a team March 31, 2022 08:25
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 31, 2022
Copy link
Member

@aledbf aledbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 9d36697 into main Mar 31, 2022
@roboquat roboquat deleted the cw/fix-9037 branch March 31, 2022 08:28
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-daemon] Remove backup limiter
3 participants