-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Purge old Workspaces at some point #11360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-gpl-clean-wss.2 because the annotations in the pull request description changed |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
deed758
to
8a5484f
Compare
looking into this, now 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! ❤️
Would be great to also delete corresponding records from
- d_b_prebuilt_workspace
- d_b_workspace_instance_user
- d_b_layout_data
Adding hold in case you want to address this in this PR.
/hold
Yes indeed... make sense to do it now I guess. Have to double-check with @jakobhero about which ones are safe, though. |
|
fee5029
to
89f2c35
Compare
89f2c35
to
c12a637
Compare
c12a637
to
3a6eb80
Compare
d2308d7
to
e6bbae0
Compare
@geropl This now has metrics also. I've bumped the retention to 3 years for now, to observe the effect. |
e6bbae0
to
d2b5408
Compare
@easyCZ Yes, looks good to me as well (cannot approve as it's my PR 🙈 )! 👍 Just to summarize:
|
/unhold 💥 |
Description
Introduces a 3rd workspace deletion state "purged" as discussed in #11378 .
Related Issue(s)
Fixes #11378
How to test
Run tests
(cd components/gitpod-db && yarn test)
Execute in preview environment
kubectl port-forward mysql-0 3306 &
mysql -u gitpod -h 127.0.0.1 -p
, PW:PW
kubectl edit cm server-config
and setworkspaceGarbageCollection.intervalSeconds
to30
(or similar)kubectl rollout restart deployment server
server
logs:wsgc: successfully purged 1 workspaces
Release Notes
Documentation
Werft options: