[installer-tests] Support tests against multiple version of k8s and ubuntu images #11568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandajavarma
force-pushed
the
nvn/fix-11349
branch
4 times, most recently
from
6d5c7aa to
2f96118
Compare
github-actions
bot
added
the
team: delivery
nandajavarma
force-pushed
the
nvn/fix-11349
branch
3 times, most recently
from
842a561 to
1fbce6f
Compare
mrsimonemms
reviewed
Aug 1, 2022
| tags = {} | ||
| api_server_authorized_ip_ranges = [] | ||
|
|
||
| kubernetes_version = var.cluster_version |
There was a problem hiding this comment.
I have a feeling that this may break in time. Azure tend to remove versions of k8s at fairly short notice, which is why the data "azurerm_kubernetes_service_versions" is the recommended way of getting the versions. You can use a version_prefix as well
My suggestion is to keep this change as you've done it, but do so in the knowledge that we may have to change it in the future.
mrsimonemms
approved these changes
Aug 1, 2022
|
/hold This only exists so you can see the comment. I'm happy for you remove it at will |
nandajavarma
force-pushed
the
nvn/fix-11349
branch
2 times, most recently
from
efd29cf to
113a1d3
Compare
nandajavarma
force-pushed
the
nvn/fix-11349
branch
from
113a1d3 to
f224bf6
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR parameterize the version of node image when possible and version of kubernetes. The node images are not configurable easily on managed self-hosted instances. We can only use the supported images corresponding to the Kubernetes version we are using. Hence the all supported ubuntu versions are tested only in the k3s setup.
Related Issue(s)
Fixes #11349
Fixes #11272
How to test
One can use any of the suggested commands in this internal document to test.
Release Notes
Documentation
Werft options: