Skip to content

optimize build of JB images #12296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2022
Merged

optimize build of JB images #12296

merged 1 commit into from
Aug 25, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 23, 2022 •
edited
Loading

Description

This PR separates download of JB backend from building JB images. It reduces the rebuild time to 15 mins instead of 25mins for the change of JB backend plugin.

Unfortunately copy step during image build gets invalidated for some reasons, so even we just change the backend plugin, copying of backend itself happens for all 8 images and it adds like 10 mins unnecessary. I will think later how to optimize father by probably decoupling deliver of plugins.

Related Issue(s)

Related to #12268

How to test

/hold
to remove test commit

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft no-test

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ak-jb-backend-via-proxy.1 because the annotations in the pull request description changed
(with .werft/ from main)

@akosyakov akosyakov changed the title serve JB backedn plugins from IDE proxy optimize build of JB images Aug 23, 2022
@akosyakov akosyakov force-pushed the ak/jb_backend_via_proxy branch from 7f550b7 to a715f81 Compare August 23, 2022 13:53
@roboquat roboquat added size/L and removed size/S labels Aug 23, 2022
@akosyakov akosyakov force-pushed the ak/jb_backend_via_proxy branch 2 times, most recently from 84ae1d3 to f6f03d1 Compare August 24, 2022 14:31
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ak-jb-backend-via-proxy.9 because the annotations in the pull request description changed
(with .werft/ from main)

@akosyakov akosyakov marked this pull request as ready for review August 24, 2022 15:00
@akosyakov akosyakov requested a review from a team August 24, 2022 15:00
@akosyakov
Copy link
Member Author

/hold
to remove test commit

@felladrin
Copy link
Contributor

felladrin commented Aug 25, 2022 •
edited by werft-gitpod-dev-com bot
Loading

ℹ️ I'm reviewing it now!

@felladrin
Copy link
Contributor

felladrin commented Aug 25, 2022 •
edited by werft-gitpod-dev-com bot
Loading

ℹ️ I'm going to restart the Preview Environment load balancer, to try solving the SSH connection problem (which happens sometimes in PrevEnvs).
image
Note: It took 10+ minutes to open the workspace in the preview environment. I also tried twice to confirm this error was not specifically with Stable or Latest IDE versions (opening one workspace at a time). Both failed with the same error.

@akosyakov
Copy link
Member Author

Maybe I broke images... Let me know if restarting did not help, then I have a look again.

felladrin
felladrin approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After restarting the load balancer the workspaces started opening fine!

I tried a few images (Stable and EAP), and they all worked! ✅

image

image

image

@akosyakov
[jb] extract downloading in own leeway component
4d7195b 
In order to reuse downloads on changes to backend plugins.
@akosyakov akosyakov force-pushed the ak/jb_backend_via_proxy branch from 1bb2f84 to 4d7195b Compare August 25, 2022 09:24
@akosyakov
Copy link
Member Author

/unhold

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ak-jb-backend-via-proxy.11 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat merged commit edc17a4 into main Aug 25, 2022
@roboquat roboquat deleted the ak/jb_backend_via_proxy branch August 25, 2022 10:35
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felladrin felladrin felladrin approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/L team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akosyakov @felladrin @roboquat