Skip to content

[dashboard] Simplify <code> snippets by using CSS instead of a whole component #12306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

jankeromnes
Copy link
Contributor

Description

Simplify <code></code> snippets by using CSS instead of a whole extra component.

Related Issue(s)

Fixes #7555

How to test

  1. Open /settings
  2. The <code> snippets should look the same as before

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Aug 23, 2022

/werft run

👍 started the job as gitpod-build-jx-code.1
(with .werft/ from main)

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Aug 23, 2022

/werft run

👍 started the job as gitpod-build-jx-code.2
(with .werft/ from main)

@jankeromnes jankeromnes marked this pull request as ready for review August 23, 2022 14:35
@jankeromnes jankeromnes requested a review from a team August 23, 2022 14:35
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 23, 2022
@jankeromnes
Copy link
Contributor Author

BEFORE AFTER
Screenshot 2022-08-23 at 16 34 08 Screenshot 2022-08-23 at 16 34 19
Screenshot 2022-08-23 at 16 34 48 Screenshot 2022-08-23 at 16 34 58
Screenshot 2022-08-23 at 16 35 23 Screenshot 2022-08-23 at 16 35 36

@jankeromnes jankeromnes requested a review from gtsiolis August 24, 2022 07:42
@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 24, 2022

Looking at this now! 👀

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another clean-up, @jankeromnes! 🧹

Although this is in a different direction from the initial discussion in #7302 (comment), I like the boring (simple) solution of using the <code> element for now. 🤝

FWIW, the CodeText component aimed at becoming a flexible solution for supporting a) single-line, b) multi-line, and c) inline code text where users could copy to clipboard via a clipboard button or by simply clicking on the inline code.

For example, to provide some more context, a user could:

  1. Go to /account and click directly on that GIT_AUTHOR_NAME variable to copy-to-clipboard.
  2. Go to /admin/settings and click on a copy to clipboard button to copy the telemetry code.
  3. ...

However, let's leave this as is for now and come back to this once we know we want to improve the interaction with the code text across the dashboard.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 8344c64 into main Sep 1, 2022
@roboquat roboquat deleted the jx/code branch September 1, 2022 08:40
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] refactor the CodeText utility component
4 participants