-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[dashboard] Simplify <code> snippets by using CSS instead of a whole component #12306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/werft run 👍 started the job as gitpod-build-jx-code.1 |
/werft run 👍 started the job as gitpod-build-jx-code.2 |
Looking at this now! 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for another clean-up, @jankeromnes! 🧹
Although this is in a different direction from the initial discussion in #7302 (comment), I like the boring (simple) solution of using the <code>
element for now. 🤝
FWIW, the CodeText
component aimed at becoming a flexible solution for supporting a) single-line, b) multi-line, and c) inline code text where users could copy to clipboard via a clipboard button or by simply clicking on the inline code.
For example, to provide some more context, a user could:
- Go to
/account
and click directly on thatGIT_AUTHOR_NAME
variable to copy-to-clipboard. - Go to
/admin/settings
and click on a copy to clipboard button to copy the telemetry code. - ...
However, let's leave this as is for now and come back to this once we know we want to improve the interaction with the code text across the dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Simplify
<code></code>
snippets by using CSS instead of a whole extra component.Related Issue(s)
Fixes #7555
How to test
/settings
<code>
snippets should look the same as beforeRelease Notes
Documentation
Werft options: