[content-service] Implement UsageReportService.DownloadURL #12335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold for dependency |
easyCZ
commented
Aug 24, 2022
| @@ -32,7 +32,7 @@ const ( | |||
|
|
|||
| var ( | |||
| // ErrNotFound is returned when an object is not found | |||
| ErrNotFound = xerrors.Errorf("not found") | |||
| ErrNotFound = fmt.Errorf("not found") | |||
There was a problem hiding this comment.
Drive-by: xerrors.Errorf is deperacted
easyCZ
force-pushed
the
mp/content-get-download-url
branch
2 times, most recently
from
6c144ec to
85dc4fb
Compare
easyCZ
force-pushed
the
mp/content-get-download-url-impl
branch
2 times, most recently
from
61b286c to
66c18fe
Compare
|
/hold for dependency |
easyCZ
changed the title
sagor999
approved these changes
Aug 25, 2022
| return nil, status.Error(codes.InvalidArgument, "Name is required but got empty.") | ||
| } | ||
|
|
||
| logger := log.WithField("name", req.Name). |
There was a problem hiding this comment.
usually we just name the variable log in cases like this.
Suggested change
| logger := log.WithField("name", req.Name). | |
| log := log.WithField("name", req.Name). |
There was a problem hiding this comment.
log is the package name where the logging is implemented. It's a name clash that we shouldn't allow.
roboquat
requested review from
csweichel,
geropl and
corneliusludmann
as code owners
easyCZ
force-pushed
the
mp/content-get-download-url-impl
branch
from
66c18fe to
26e93b8
Compare
|
dependency landed |
jenting
approved these changes
Aug 26, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements DownloadURL rpc. This is needed to be able to download a usage report form the usage component.
Related Issue(s)
How to test
Release Notes
Documentation
Werft options: