[installer-tests] Add annotations to Cron job files #12380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team: delivery
nandajavarma
force-pushed
the
nvn/fix-cron-files
branch
from
2201f5a to
0fd7460
Compare
nandajavarma
force-pushed
the
nvn/fix-cron-files
branch
from
0fd7460 to
3ecbe48
Compare
nandajavarma
force-pushed
the
nvn/fix-gcp-db
branch
3 times, most recently
from
bd2bb6d to
cade635
Compare
nandajavarma
force-pushed
the
nvn/fix-cron-files
branch
from
3ecbe48 to
61a7be3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main goal of this PR is to remove the extra unnecessary file
self-hosted-installer-tests.yaml. When running tests since they get the name of the cron file involved, running 4 environment tests as 4 different files, we can see 4 different job status during the upgrade test. This will be super useful for visibility and job status tracking.Along with this I am pushing in two small changes, parameterization of two values, the domain name and the KOTS app name. Currently this is still hardcoded in several places, but this makes it easier to test during development considering we have limited certificates for
gitpod-self-hosted.com. With this change, one can change the domain in the files:.werft/installer-tests.tf,install/tests/Makefileandinstall/tests/main.tfto use a domain likedoptig.com. This will be made easily configurable in the future.Related Issue(s)
Fixes #
How to test
One can try running any of the following:
Release Notes
Documentation
Werft options: