Skip to content

Add beta label on usage #12412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Add beta label on usage #12412

merged 1 commit into from
Sep 14, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Aug 25, 2022

Description

This will add a BETA label on the usage page with a link to send feedback.

We need a public feedback issue to link to. 💡

Opened this after we briefly discussed this with @laushinka in a recent social call. 🍷

How to test

Go to usage and notice the new beta notice on the left sidebar.

Screenshot 2022-09-13 at 4 07 55 PM

Release Notes

Add beta notice and label on usage

Werft options:

  • /werft with-preview
  • /werft with-payment

@gtsiolis gtsiolis requested a review from a team August 25, 2022 21:01
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 25, 2022
</PillLabel>{" "}
</div>
<div>
<a href="#" class="gp-link">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue(blocking): Before merging this, make sure there's a public feedback issue that we link to. 💡

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 25, 2022

@jldec WDYT? Alternatively, we could make the label more prominent by placing it next to the tab itself, see screenshot below. I think it's worth marking this as beta, more than Teams & Projects which is far more stable, especially since this could involve charges, etc. 💸

Screenshot 2022-08-26 at 12 09 47 AM

@gtsiolis gtsiolis marked this pull request as draft August 25, 2022 21:10
@filiptronicek
Copy link
Member

filiptronicek commented Aug 25, 2022

👀 I think like the label in the tab even more. It makes it clear this feature is in beta right from the get go - even before clicking on the section.

I am unsure though if this is worth giving up the nice Send feedback link.

@gtsiolis gtsiolis force-pushed the gt/add-label-beta-on-usage branch from a0638f5 to 83dab69 Compare August 25, 2022 21:50
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-add-label-beta-on-usage.2 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 26, 2022

/werft run with-preview with-payment

👍 started the job as gitpod-build-gt-add-label-beta-on-usage.3
(with .werft/ from main)

@gtsiolis gtsiolis closed this Sep 5, 2022
@gtsiolis gtsiolis force-pushed the gt/add-label-beta-on-usage branch from 83dab69 to 536a13d Compare September 5, 2022 13:43
@roboquat roboquat added size/XS and removed size/S labels Sep 5, 2022
@gtsiolis gtsiolis reopened this Sep 5, 2022
@roboquat roboquat added size/S and removed size/XS labels Sep 5, 2022
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 5, 2022

/werft run with-preview with-payment

👍 started the job as gitpod-build-gt-add-label-beta-on-usage.6
(with .werft/ from main)

@gtsiolis gtsiolis force-pushed the gt/add-label-beta-on-usage branch from b73f401 to 3309d65 Compare September 12, 2022 09:00
@gtsiolis gtsiolis marked this pull request as ready for review September 12, 2022 09:01
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 12, 2022

/werft run with-preview with-payment

👍 started the job as gitpod-build-gt-add-label-beta-on-usage.8
(with .werft/ from main)

@laushinka
Copy link
Contributor

This looks good! For my missing context, what was the reason that it was closed before?

@gtsiolis gtsiolis force-pushed the gt/add-label-beta-on-usage branch from 3309d65 to 0a43f5a Compare September 13, 2022 12:35
@roboquat roboquat added size/M and removed size/S labels Sep 13, 2022
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 13, 2022

@laushinka If you are referring to the closing in #12412 (comment), that was by accident while rebasing and pushing no commits to the branch. 😇

Resolved conflicts and added the missing issue link in the <a> element.

I've also replaced the Beta label with an Early Access label to be aligned with the upcoming changes in https://github.com/gitpod-io/website/pull/2715. Updated the screenshot in the PR description. Cc @jldec

@laushinka
Copy link
Contributor

laushinka commented Sep 13, 2022

@laushinka If you are referring to the closing in #12412 (comment), that was by accident while rebasing and pushing no commits to the branch. 😇

Aha, got it. Btw the PR didn't create any previews. Do the labels in the description work that way? I usually always create the two tags in two lines.

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-add-label-beta-on-usage.11 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 13, 2022

Btw the PR didn't create any previews. Do the labels in the description work that way? I usually always create the two tags in two lines.

@laushinka If you mean the Werft options in the PR description, they don't work inline. The PR was opened before I learned we need to use two lines for this to work, see relevant discussion.

Let me update the PR description and re-trigger a preview env.

/werft with-preview with-payment

👎 unknown command: with-preview
Use /werft help to list the available commands

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 13, 2022

/werft run with-preview with-payment

👍 started the job as gitpod-build-gt-add-label-beta-on-usage.12
(with .werft/ from main)

Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding hold in case you wanted to do any additional validation or changes.
Screenshot 2022-09-14 at 11 02 45

/hold

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 14, 2022

Thanks @laushinka and @easyCZ for taking a look, and thanks @easyCZ for adding the hold!

To unblock this, I've replaced the Early Access label with a Beta label so that the Learn more link makes sense as Early Access is a new term that does not exist yet in our docs until we merge https://github.com/gitpod-io/website/pull/2715. Once https://github.com/gitpod-io/website/pull/2715 is merged we can open a small PR to rename the label. 🛹

/unhold

@gtsiolis gtsiolis force-pushed the gt/add-label-beta-on-usage branch from a18276d to 074202d Compare September 14, 2022 12:18
@roboquat roboquat merged commit d224833 into main Sep 14, 2022
@roboquat roboquat deleted the gt/add-label-beta-on-usage branch September 14, 2022 12:30
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants