-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add beta label on usage #12412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beta label on usage #12412
Conversation
</PillLabel>{" "} | ||
</div> | ||
<div> | ||
<a href="#" class="gp-link"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue(blocking): Before merging this, make sure there's a public feedback issue that we link to. 💡
👀 I think like the label in the tab even more. It makes it clear this feature is in beta right from the get go - even before clicking on the section. I am unsure though if this is worth giving up the nice Send feedback link. |
a0638f5
to
83dab69
Compare
started the job as gitpod-build-gt-add-label-beta-on-usage.2 because the annotations in the pull request description changed |
/werft run with-preview with-payment 👍 started the job as gitpod-build-gt-add-label-beta-on-usage.3 |
83dab69
to
536a13d
Compare
/werft run with-preview with-payment 👍 started the job as gitpod-build-gt-add-label-beta-on-usage.6 |
b73f401
to
3309d65
Compare
/werft run with-preview with-payment 👍 started the job as gitpod-build-gt-add-label-beta-on-usage.8 |
This looks good! For my missing context, what was the reason that it was closed before? |
3309d65
to
0a43f5a
Compare
@laushinka If you are referring to the closing in #12412 (comment), that was by accident while rebasing and pushing no commits to the branch. 😇 Resolved conflicts and added the missing issue link in the I've also replaced the Beta label with an Early Access label to be aligned with the upcoming changes in https://github.com/gitpod-io/website/pull/2715. Updated the screenshot in the PR description. Cc @jldec |
Aha, got it. Btw the PR didn't create any previews. Do the labels in the description work that way? I usually always create the two tags in two lines. |
started the job as gitpod-build-gt-add-label-beta-on-usage.11 because the annotations in the pull request description changed |
@laushinka If you mean the Werft options in the PR description, they don't work inline. The PR was opened before I learned we need to use two lines for this to work, see relevant discussion. Let me update the PR description and re-trigger a preview env. /werft with-preview with-payment 👎 unknown command: with-preview |
/werft run with-preview with-payment 👍 started the job as gitpod-build-gt-add-label-beta-on-usage.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0e339d9
to
a18276d
Compare
Thanks @laushinka and @easyCZ for taking a look, and thanks @easyCZ for adding the hold! To unblock this, I've replaced the Early Access label with a Beta label so that the Learn more link makes sense as Early Access is a new term that does not exist yet in our docs until we merge https://github.com/gitpod-io/website/pull/2715. Once https://github.com/gitpod-io/website/pull/2715 is merged we can open a small PR to rename the label. 🛹 /unhold |
a18276d
to
074202d
Compare
Description
This will add a BETA label on the usage page with a link to send feedback.
We need a public feedback issue to link to. 💡
Opened this after we briefly discussed this with @laushinka in a recent social call. 🍷
How to test
Go to usage and notice the new beta notice on the left sidebar.
Release Notes
Werft options: