Skip to content

Add clarification for werft annotations in the PR description #12432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

vulkoingim
Copy link
Contributor

Description

Add clarification for werft annotations in the PR description

Release Notes

NONE

Werft options:

  • /werft with-preview

@vulkoingim
Copy link
Contributor Author

vulkoingim commented Aug 26, 2022

/werft run

👍 started the job as gitpod-build-aa-template.1
(with .werft/ from main)

@vulkoingim vulkoingim requested a review from a team August 26, 2022 11:53
Copy link
Contributor

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well thought!

@ArthurSens
Copy link
Contributor

ArthurSens commented Aug 26, 2022

/hold

I've just noticed the failed build 🤔

@vulkoingim
Copy link
Contributor Author

vulkoingim commented Aug 26, 2022

/werft run

👍 started the job as gitpod-build-aa-template.7
(with .werft/ from main)

@roboquat roboquat merged commit b02fbe8 into main Aug 29, 2022
@roboquat roboquat deleted the aa/template branch August 29, 2022 12:48
@mads-hartmann
Copy link
Contributor

mads-hartmann commented Aug 29, 2022

@vulkoingim We'll have to revert this PR I'm afraid afraid, it appears Werft also parses commands in comments ☺️ See the latests builds on main (they have with-preview-with-payment enabled 🤪)
Screenshot 2022-08-29 at 19 57 06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants