Fix default workspace class is not selected #12436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-furisto-default-workspace-class-12435.2 because the annotations in the pull request description changed |
Furisto
force-pushed
the
furisto/default-workspace-class-12435
branch
3 times, most recently
from
0004d16 to
51fc7bd
Compare
roboquat
added
size/S
release-note-none
and removed
size/M
do-not-merge/release-note-label-needed
labels
easyCZ
reviewed
Aug 29, 2022
| @@ -265,6 +266,9 @@ const gitpodServiceMock = createServiceMock({ | |||
| }, | |||
| }; | |||
| }, | |||
| getBillingModeForUser: async () => { | |||
There was a problem hiding this comment.
This seems unrelated to the PR, why is this change needed?
There was a problem hiding this comment.
The settings page calls this method and if it is not there the page cannot be displayed when using the service mock.
Furisto
force-pushed
the
furisto/default-workspace-class-12435
branch
from
51fc7bd to
a93f029
Compare
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show the workspace class that will be used if no workspace class has been selected yet by the user.
Related Issue(s)
Fixes #12435
How to test
Release Notes
Werft options: