Enforce no-unused-locals in .werft #12525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mads-hartmann
force-pushed
the
mads/no-unused-locals
branch
from
1db83c9 to
da93d41
Compare
github-actions
bot
added
team: devx
team: delivery
vulkoingim
approved these changes
Aug 31, 2022
mrsimonemms
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enabled the
no-unused-localsTypeScript compiler option and then removes all the unused local variables form the code.Related Issue(s)
No issue
How to test
tsc --noEmitin .werft is still successful. I triggered the job manually here to ensure the my code was executed by werft.Release Notes
Documentation
N/A
Werft options: