[code-browser] extensions observabiilty #12539
Conversation
|
/werft run 👍 started the job as gitpod-build-akosyakov-code-browser-observability-11608.4 |
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
akosyakov
force-pushed
the
akosyakov/code-browser-observability-11608
branch
from
3995d70 to
2a5af62
Compare
|
started the job as gitpod-build-akosyakov-code-browser-observability-11608.6 because the annotations in the pull request description changed |
akosyakov
force-pushed
the
akosyakov/code-browser-observability-11608
branch
14 times, most recently
from
a38fcea to
0f4d5dc
Compare
akosyakov
changed the title
akosyakov
force-pushed
the
akosyakov/code-browser-observability-11608
branch
2 times, most recently
from
13f804c to
a034b6d
Compare
|
@akosyakov is an extension uninstall considered as an "operation"? |
yes [1], you can filter them out if you are not interested to see |
|
Please ignore failed build, prev envs should be good to use. It is something funny with werft job check, see https://gitpod.slack.com/archives/C032A46PWR0/p1662128693010439 |
There was a problem hiding this comment.
Tested as per testing steps and seems to work well, tried installing, uninstalling and also installing via Settings Sync. Everything good, filtering by operation in Grafana also shows the events are correctly named.
Updating extensions, although not pictured below are working as well.
Thanks Anton! 🧡✅
/hold
| --plugin=protoc-gen-grpc-web=/tmp/protoc-gen-grpc-web \ | ||
| --js_out=import_style=commonjs:lib \ | ||
| --grpc-web_out=import_style=commonjs+dts,mode=grpcweb:lib \ | ||
| --plugin="protoc-gen-ts=$DIR/node_modules/.bin/protoc-gen-ts" \ |
There was a problem hiding this comment.
I remember there has some reason cause I was not able to use this library, maybe this one is not supported optional value?, or it's don't typescript?
There was a problem hiding this comment.
improbable-eng/grpc-web does not support it, but it is also fine we default that everything is optional by default in other places
|
/werft run 👍 started the job as gitpod-build-akosyakov-code-browser-observability-11608.25 |
akosyakov
force-pushed
the
akosyakov/code-browser-observability-11608
branch
from
a034b6d to
345ccc3
Compare
|
/unhold |
|
Build failed. Adding hold to unblock merge queue. /hold |
|
@easyCZ it is weird, the last job is successful: https://werft.gitpod-dev.com/job/gitpod-build-akosyakov-code-browser-observability-11608.27 |
|
I think a race happened. Github points to https://werft.gitpod-dev.com/job/gitpod-build-akosyakov-code-browser-observability-11608.26 while there's a newer one (.27). I think a re-run should fix this for you. |
|
/werft run 👍 started the job as gitpod-build-akosyakov-code-browser-observability-11608.28 |
@easyCZ there's a short thread here were I explain the cause |
|
@akosyakov It still has the hold label, so it's not being merged automatically yet |
|
/unhold |
roboquat
added
deployed: IDE
Description
This PR adds RED metrics for queries to the extension gallery and user operations to manage extensions like install and uninstall from user perspective. It allows unambiguously gauge impact of a situation when open-vsx.org is unavailable, i.e. whether our caches are helpful.
VC Code extensions observability - Watch Video
A supporting PR in openvsscode-server: gitpod-io/openvscode-server#422
Related Issue(s)
Fixes #11608
How to test
./dev/preview/portforward-monitoring-satellite.sh -c harvesterVS Code Browser Overviewdashboard under IDE Team folder. You can see throughput of queries to the extension gallery, failure rates and latency as its observed by end users. You can also review throughput of user operations like extension installation/uninstallation/upgrade, its failure rates and latencies.Release Notes
Documentation
Werft options: