Skip to content

[agent-smith] Add more details to the infringement #12556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

[agent-smith] Add more details to the infringement #12556

merged 1 commit into from
Sep 12, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 31, 2022 •
edited by Furisto
Loading

How to test

  • Open a workspace that triggers an infringement rule
  • Check agent-smith log. It should contains a new CommandLine field.

Release Notes

NONE

Werft options:

  • /werft with-preview

@roboquat roboquat added size/XS and removed size/S labels Sep 1, 2022
@aledbf aledbf marked this pull request as ready for review September 12, 2022 10:52
@aledbf aledbf requested a review from a team September 12, 2022 10:52
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Sep 12, 2022
@Furisto
Copy link
Member

Furisto commented Sep 12, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview

👍 started the job as gitpod-build-aledbf-asd.5
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-asd.7 because the annotations in the pull request description changed
(with .werft/ from main)

@Furisto
Copy link
Member

Furisto commented Sep 12, 2022

I rebased the branch because the deployment is failing. Probably due to this commit.

@Furisto
Copy link
Member

Furisto commented Sep 12, 2022

Works as expected
{"infringement":[{"Description":"graded.composite.commandline: matched \"watch\"","Kind":"very blocklisted executable","CommandLine":["watch","echo","hello"]}],"instanceId":"8a46f229-b294-4848-af8d-bba17a558609","level":"info","message":"stopping workspace and blocking user",

@roboquat roboquat merged commit 384a0e7 into main Sep 12, 2022
@roboquat roboquat deleted the aledbf/asd branch September 12, 2022 11:58
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Furisto Furisto Furisto approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @Furisto @roboquat