-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[installer] change blobserve node to workload_ide #12558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7e03460
to
d45e958
Compare
@iQQBot Should I fix it somehow? |
I think we should ask @gitpod-io/engineering-self-hosted to verify, i.e. use this version to reinstall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/hold
please merge when you are comfortable
started the job as gitpod-build-pd-fix-blobserve.2 because the annotations in the pull request description changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm broadly ok with this change, but I don't know the implications of changing the network policies. My recollection from when we did this is that it was only implemented in GKE (not EKS, AKS or k3s).
It's worth running the test suites we have. You'll need to load this PR in a workspace, and then run:
werft run github -j .werft/gke-installer-tests.yaml -a skipTests=true
werft run github -j .werft/aks-installer-tests.yaml -a skipTests=true
werft run github -j .werft/k3s-installer-tests.yaml -a skipTests=true
werft run github -j .werft/eks-installer-tests.yaml -a skipTests=true
There's a possibility that these may fail due to these tests being fairly new, but this should give us an idea if this change creates any regressions.
started the job as gitpod-build-pd-fix-blobserve.3 because the annotations in the pull request description changed |
The role of network policy is 2 parts One is to restrict access to certain non-public services, such as The other role is to unrestrict access and prevent other network policies from acting on this pod For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the PR and it seems to fix the issue. Thank you very much @iQQBot for investigating this! 🚀
And sorry that it took so long on my end.
/unhold
Description
This PR move blobserve to
workload_ide
node, because traffic throughide-proxy
This PR also adjust blobserve network policy, in order to support some edge case see internal discuss
Related Issue(s)
Fixes #12366
How to test
Release Notes
Documentation
Werft options: