Fix for Webhook Event GC #12559
Merged
Fix for Webhook Event GC #12559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-at-test-events.2 |
AlexTugarev
changed the title
AlexTugarev
force-pushed
the
at/test-events
branch
from
3b906c4 to
a591c0b
Compare
AlexTugarev
commented
Aug 31, 2022
| .update() | ||
| .set({ deleted: true }) | ||
| .where("event.creationTime < :expirationDate", { expirationDate }); |
There was a problem hiding this comment.
for some reasons, aliasing doesn't work with typeorm here. 🤷🏻
svenefftinge
approved these changes
Sep 1, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing DB query with test. This is currently broken on main/prod :-(
Aftermath of #12472 (comment)
how to test
run db-test or check the test logs of the werft job and find the ✔️ passing test in there