[usage] Fix test for listing usage with pagination #12562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
commented
Aug 31, 2022
| @@ -204,112 +201,87 @@ func TestUsageService_ListBilledUsage_Pagination(t *testing.T) { | |||
| } | |||
|
|
|||
| scenarios := []Scenario{ | |||
| (func() Scenario { | |||
There was a problem hiding this comment.
This wrapping in a self-invoking anonymous function isn't needed. It would be useful we wanted to do some imperative work, but we're doing only declarative statements.
easyCZ
commented
Aug 31, 2022
| @@ -175,11 +175,8 @@ func TestUsageService_ListBilledUsage_Pagination(t *testing.T) { | |||
| ctx := context.Background() | |||
|
|
|||
| type Expectation struct { | |||
| count int64 | |||
There was a problem hiding this comment.
these properties were not used in the test anywhere...
|
started the job as gitpod-build-mp-usage-fix-tests.1 because the annotations in the pull request description changed |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are test hooks for record deletion. However, these wouldn't run after each test when the test setup up was hooked up to the top level
*testing.T(because the hook would only run after they finished). Instead, we need to bind the hooks to each subtest.Related Issue(s)
Fixes unit tests from #12562
How to test
unit tests
Release Notes
Documentation
Werft options: