-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Enable connection limiting for free tier #12585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eb31572
to
cc971a7
Compare
/werft run with-payment 👍 started the job as gitpod-build-fo-netlimit-annotation.7 |
cc971a7
to
c5ac861
Compare
/werft run with-payment 👍 started the job as gitpod-build-fo-netlimit-annotation.9 |
@geropl PTAL |
const wsConnectionLimitingEnabled = await getExperimentsClientForBackend().getValueAsync( | ||
"workspace_connection_limiting", | ||
false, | ||
{ user }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the additional turn-around, but: I think It make sense to also sent teams
. We already fetch it below (line 878) so we can just pull it up. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as advertised ✔️
/hold because I think it's worth addressing this comment, but leave it up to you to decide.
c5ac861
to
4f27800
Compare
/unhold |
Description
This instructs ws-manager to limit the rate of network connections for non paying customers. Note that this currently only audits (i.e. it records packets that would have been dropped but does not actually drop them). We will use this to refine the limits.
Related Issue(s)
Fixes #13041
How to test
User on free tier
gitpod.io/netConnLimitPerMinute
annotationwill limit network connections
. You can also ssh into the node and then enter the network namespace of the pod withnsenter -t pid -n
. nft list ruleset should show you a bunch of rules in that namespace.Paying customer
gitpod.io/netConnLimitPerMinute
annotationRelease Notes
Werft options: