Skip to content

Align GCP Single Cluster TF Database Output with Installation UI #12586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

lucasvaltl
Copy link
Contributor

Description

Reorders the output of the make output command for the GCP single cluster terraform config. Specifically, the "tick Google Cloud SQL proxy" instruction is moved to the top of the database section, because this is also where it is in the UI itself.

How to test

  • Look at changed files :)

Release Notes

NONE

@lucasvaltl lucasvaltl requested a review from a team September 1, 2022 15:11
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 1, 2022
@lucasvaltl lucasvaltl changed the title reorder database output Align GCP Single Cluster TF Database Output with Installation UI Sep 1, 2022
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about approving such a massive change :)

@roboquat roboquat merged commit 3363bd9 into main Sep 1, 2022
@roboquat roboquat deleted the lv-reorder-db-tf-output branch September 1, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants