Skip to content

[UBP] Add a stale data warning to the Usage view #12624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2022
Merged

[UBP] Add a stale data warning to the Usage view #12624

merged 1 commit into from
Sep 2, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Sep 2, 2022 •
edited
Loading

Description

Add a short message to the usage view to show that the data is not guaranteed to be up to date.

image

Related Issue(s)

Part of #12064

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

Change usage page subtitle
1d8afc9 
To indicate that data on the page may be stale.
@andrew-farries andrew-farries requested a review from a team September 2, 2022 15:57
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 2, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-af-message-on-usage-view.6 because the annotations in the pull request description changed
(with .werft/ from main)

geropl
geropl approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue for now with minimal effort 🎯 - thanks!

@roboquat roboquat merged commit 763cf3e into main Sep 2, 2022
@roboquat roboquat deleted the af/message-on-usage-view branch September 2, 2022 16:06
@andrew-farries andrew-farries mentioned this pull request Sep 2, 2022
Closed
1 task
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrew-farries @geropl @roboquat