Previews: Always use CLI installer to install monitoring-satellite, instead of jsonnet #12626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eviews Signed-off-by: ArthurSens <[email protected]>
Signed-off-by: ArthurSens <[email protected]>
Signed-off-by: ArthurSens <[email protected]>
vulkoingim
approved these changes
Sep 6, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #12039, we introduced two methods for installing monitoring-satellite in preview environments. This way we could let our colleagues have monitoring-satellite safely installed using the traditional Jsonnet way, while we could have a mechanism to use our CLI installer and verify that things are working as expected.
We've successfully migrated all our apps to our new installer, and previews are the last missing piece. This PR makes our CLI the default installation method for monitoring-satellite, and also removes the code for the jsonnet installation method completely.
How to test
werft run github -f -a with-previewmonitoring-satellitenamespace.Release Notes
Werft options: