-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[usage] Add database functions for new usage control loop #12643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4590a60
to
f6d86c6
Compare
6381a8a
to
ab11df3
Compare
ab11df3
to
9ef1e18
Compare
easyCZ
reviewed
Sep 5, 2022
require.Equal(t, updatedDesc, drafts[0].Description) | ||
} | ||
|
||
func TestFindAllDraftUsage(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
easyCZ
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. We reviewed this together on a call.
/hold in case you want to make any last changes
9ef1e18
to
4bdf2c0
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: webapp
Meta team change is running in production
deployed
Change is completely running in production
release-note-none
size/XL
team: webapp
Issue belongs to the WebApp team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds ways to retrieve and store records from
d_b_usage
as well as functions to retrieve workspace instances to consider in a control loop.The anticipated control loop would work as follows:
d_b_usage
workspaceInstanceId
exists in draftsWe could potentially combine 2,3,4 in one query but we should also allow for only running Step 2) to seed the past without considering running instances.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: