[usage] Find running and stopped instances in ledger reconciler #12645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
commented
Sep 5, 2022
|
|
||
| client := v1.NewUsageServiceClient(conn) | ||
|
|
||
| _, err = client.ReconcileUsageWithLedger(context.Background(), &v1.ReconcileUsageWithLedgerRequest{ |
There was a problem hiding this comment.
Doesn't assert the right instances were found because we don't yet update the records in any way. Once we start updating, the test here will be extended to do that.
easyCZ
force-pushed
the
mp/ledger-collect-instances
branch
from
84d3aad to
c825b27
Compare
svenefftinge
approved these changes
Sep 5, 2022
| type Usage struct { | ||
| ID uuid.UUID `gorm:"primary_key;column:id;type:char;size:36;" json:"id"` | ||
| AttributionID AttributionID `gorm:"column:attributionId;type:varchar;size:255;" json:"attributionId"` | ||
| Description string `gorm:"column:description;type:varchar;size:255;" json:"description"` | ||
| CreditCents int64 `gorm:"column:creditCents;type:bigint;" json:"creditCents"` | ||
| EffectiveTime VarcharTime `gorm:"column:effectiveTime;type:varchar;size:255;" json:"effectiveTime"` | ||
| Kind string `gorm:"column:kind;type:char;size:10;" json:"kind"` | ||
| Kind UsageKind `gorm:"column:kind;type:char;size:10;" json:"kind"` |
| logger.WithError(err).Errorf("Failed to find all draft usage records.") | ||
| return nil, status.Errorf(codes.Internal, "failed to find all draft usage records") | ||
| } | ||
| logger.Infof("Found %d draft usage records.", len(usageDrafts)) |
There was a problem hiding this comment.
We'll also need to fetch the instances for the drafts and then combine the three slices of instances. But that's part of the next iteration I guess?
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ledger Reconciler finds running and stopped instances. Reconciler will be extended in subsequent PRs.
Related Issue(s)
Fixes #
How to test
Unit tests
Release Notes
Documentation
Werft options: