[installer-tests] fix azure authentication #12665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pothulapati
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Haven't specifically tested it, but manually logging in using the az cli before we can retrieve the kubeconfig doesn't sound wrong.
Looks like it is a known issue where the CLI has to write to disk, and cannot directly use the env variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, for the cleanup job, we try to get the kubeconfig file so as to delete the gitpod installation, external-dns etc. that will remove loadbalancers and such. In azure, the aws cli is currently throwing an error saying it is not logged in. It turns out, it isn't automatically picking up the env vars anymore, we have to explicitly login using them. This PR logs in using azure cli before getting the kubeconfig.
Related Issue(s)
Fixes #
How to test
You can try exporting the suggested env vars, and running
make azure-kubeconfigfrominstall/tests/directory.Release Notes
Documentation
Werft options: