-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[dashboard] Remove Pointer cls from Team TimeStamp #12699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/werft run with-preview with-payment 👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.0 |
/werft run with-preview with-payment 👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.1 |
/werft run with-preview 👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @skrmain for contributing! 🍊
UX changes LGTM! ✔️
I'll leave this on hold because:
- You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓
- Someone from the
@gitpod-io/engineering-webapp
still needs to approve to unblock merging. 👀 - The builds[1][2][3] are also failing, maybe someone from the
@gitpod-io/engineering-webapp
can help—I've also cross-posted this in a relevant discussion (internal). 📦
/hold
/werft run with-preview with-payment 👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.3 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/unhold |
/hold (to unblock merge queue) |
/unhold |
let's keep it hold, as there is the CA stuff still pending. /hold |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
hi @skrmain, For us to be able to merge this PR, can you please sign our CLA via this DocuSign form? If there are any questions, you can reach me via [email protected]. |
Hi @meysholdt I have Finished the CLA signing Process. |
Thank you for signing the CLA, @skrmain! |
Thanks everyone! /unhold |
/werft run with-preview with-payment 👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.4 |
/hold /werft run with-preview with-payment with-clean-slate-deployment 👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.5 As it blocks tide merge pool |
@skrmain Could you rebase against the |
@skrmain Revert(drop) the last commit (commit to merge main) and use |
/werft run with-preview with-payment with-clean-slate-deployment 👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.6 |
Hi @gtsiolis I have Rebased and Pushed... |
/unhold |
Thanks @skrmain @mustard-mh @meysholdt @aledbf @svenefftinge! 🏁 |
Description
This PR remove the
cursor-pointer
andcol-span-3
from TimeStamp Field in Teams Dashboard PageRelated Issue(s)
Fixes #12581
How to test
Release Notes
Documentation
Werft options: