Skip to content

[dashboard] Remove Pointer cls from Team TimeStamp #12699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2022
Merged

[dashboard] Remove Pointer cls from Team TimeStamp #12699

merged 1 commit into from
Oct 14, 2022

Conversation

skrmain
Copy link
Contributor

@skrmain skrmain commented Sep 6, 2022

Description

This PR remove the cursor-pointer and col-span-3 from TimeStamp Field in Teams Dashboard Page

Related Issue(s)

Fixes #12581

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 8, 2022

/werft run with-preview with-payment

👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.0
(with .werft/ from main)

@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 8, 2022

/werft run with-preview with-payment

👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.1
(with .werft/ from main)

@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 8, 2022

/werft run with-preview

👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.2
(with .werft/ from main)

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skrmain for contributing! 🍊

UX changes LGTM! ✔️

I'll leave this on hold because:

  1. You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓
  2. Someone from the @gitpod-io/engineering-webapp still needs to approve to unblock merging. 👀
  3. The builds[1][2][3] are also failing, maybe someone from the @gitpod-io/engineering-webapp can help—I've also cross-posted this in a relevant discussion (internal). 📦

/hold

@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 8, 2022

/werft run with-preview with-payment

👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.3
(with .werft/ from main)

@stale
Copy link

stale bot commented Sep 26, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 26, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Sep 26, 2022
@svenefftinge
Copy link
Member

/unhold

@aledbf
Copy link
Member

aledbf commented Sep 26, 2022

/hold

(to unblock merge queue)

@aledbf
Copy link
Member

aledbf commented Sep 26, 2022

/unhold

@svenefftinge
Copy link
Member

let's keep it hold, as there is the CA stuff still pending.

/hold

@stale
Copy link

stale bot commented Oct 12, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 12, 2022
@meysholdt
Copy link
Member

hi @skrmain, For us to be able to merge this PR, can you please sign our CLA via this DocuSign form? If there are any questions, you can reach me via [email protected].

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Oct 13, 2022
@skrmain
Copy link
Contributor Author

skrmain commented Oct 13, 2022

Hi @meysholdt

I have Finished the CLA signing Process.

@meysholdt meysholdt added cla: accepted ✔️ and removed do-not-merge/cla-pending CLA has not been signed labels Oct 14, 2022
@meysholdt
Copy link
Member

Thank you for signing the CLA, @skrmain!

@gtsiolis
Copy link
Contributor

Thanks everyone!

/unhold

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 14, 2022

/werft run with-preview with-payment

👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.4
(with .werft/ from main)

@mustard-mh
Copy link
Contributor

mustard-mh commented Oct 14, 2022

/hold

/werft run with-preview with-payment with-clean-slate-deployment

👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.5
(with .werft/ from main)

As it blocks tide merge pool

@gtsiolis
Copy link
Contributor

@skrmain Could you rebase against the main branch and push again?

@mustard-mh
Copy link
Contributor

mustard-mh commented Oct 14, 2022

skrmain Could you rebase against the main branch and push again?

@skrmain Revert(drop) the last commit (commit to merge main) and use git rebase origin/main should help 🙏

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 14, 2022

/werft run with-preview with-payment with-clean-slate-deployment

👍 started the job as gitpod-build-skr-rm-pointer-cls-dashboard-fork.6
(with .werft/ from main)

@skrmain
Copy link
Contributor Author

skrmain commented Oct 14, 2022

Hi @gtsiolis

I have Rebased and Pushed...

@mustard-mh
Copy link
Contributor

/unhold

@roboquat roboquat merged commit 56577a1 into gitpod-io:main Oct 14, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 14, 2022

Thanks @skrmain @mustard-mh @meysholdt @aledbf @svenefftinge! 🏁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the pointer cursor on the timestamp column in team usage page
7 participants