-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Install monitoring-satellite with obs-installer #12701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-aa-obs-installer-ss.1 because the annotations in the pull request description changed |
|
||
obsDir="${SCRIPT_PATH}/observability" | ||
mkdir -p "${obsDir}" | ||
git clone https://roboquat:"$(cat /mnt/secrets/monitoring-satellite-preview-token/token)"@github.com/gitpod-io/observability.git "${obsDir}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should replace this with go install
, if this fixes the issue #12703
2e7e16b
to
de080f4
Compare
Hey aleks, I couldn't really understand what problems we're solving by using shell instead of typescript here 🤔 Could you elaborate a bit? |
I assume that's because it's easier to test: run the bash script from your workspace instead of running the full werft job. That's in the spirit of the discussion we had in the platform sync on Monday: Have reusable modules that can be executed individually rather than one looong spaghetti. With that being said, it does not need to be bash, it just needs to be decoupled from the job. |
In essence the As to why use shell, instead of typescript - there are a couple of reasons:
|
f1bd9bf
to
2f18757
Compare
2f18757
to
89fc98f
Compare
Here's the custom job: https://werft.gitpod-dev.com/job/gitpod-custom-aa-obs-installer-ss.16 /werft run 👍 started the job as gitpod-build-aa-obs-installer-ss.12 |
Description
Related Issue(s)
Fixes https://github.com/gitpod-io/ops/issues/3585
How to test
https://werft.gitpod-dev.com/job/gitpod-custom-aa-obs-installer-ss.11 (fixed the popd issue with the last commit)
Release Notes
Werft options: