[stripe] Use attributionId in stripe queries in usage #12755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/stripe-use-attribution-id-metdata
branch
from
f036a1e to
43fb82c
Compare
easyCZ
changed the title
easyCZ
force-pushed
the
mp/stripe-use-attribution-id-metdata
branch
from
43fb82c to
bba700f
Compare
1 task
easyCZ
force-pushed
the
mp/stripe-use-attribution-id-metdata
branch
2 times, most recently
from
cfe8ef9 to
713cf9b
Compare
easyCZ
force-pushed
the
mp/stripe-use-attribution-id-metdata
branch
from
713cf9b to
c2d4b28
Compare
1 task
svenefftinge
approved these changes
Sep 9, 2022
| }) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to register usage for customer %q on subscription item %s", customer.Name, subscriptionItemId) | ||
| } | ||
|
|
||
| return &UsageRecord{ | ||
| SubscriptionItemID: subscriptionItemId, | ||
| Quantity: summary.Credits, | ||
| Quantity: credits, |
There was a problem hiding this comment.
nit: do we use this struct anywhere? the name UsageRecord might be a bit confusing given we have records called Usage.
There was a problem hiding this comment.
Fair. It was mostly to return something from the method but we can easily return a tuple instead.
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Customers in staging & prod have been udpated to additively contain
attributionIdmetadata.Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: