Skip to content

[Admin] Show BillingMode on Team-/UserDetails pages #12770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2022
Merged

[Admin] Show BillingMode on Team-/UserDetails pages #12770

merged 4 commits into from
Sep 9, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 8, 2022 •
edited
Loading

Description

Related Issue(s)

Fixes #

How to test

  • signup
  • ping me for admin rights (or get them through DB)
  • Search for you user details page and see that:
    • BillingMode is displayed and shows "Chargebee"
    • Chargebee stuff is displayed as well (credits, etc.)

image

  • create a team starting with Gitpod-xxx

  • Go back to User Details and see that:

    • BillingMode is displayed and shows "usage-based"
    • Chargebee related info and actions is gone
      image

  • go to your teams details page and see that:

    • BillingMode is displayed and shows "usage-based"

image

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

@geropl geropl requested a review from a team September 8, 2022 12:32
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 8, 2022
@roboquat roboquat added the size/L label Sep 8, 2022
@geropl geropl marked this pull request as draft September 8, 2022 15:46
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gpl-12674-bm.4 because the annotations in the pull request description changed
(with .werft/ from main)

@geropl geropl marked this pull request as ready for review September 9, 2022 06:44
@geropl geropl marked this pull request as draft September 9, 2022 06:47
@geropl geropl marked this pull request as ready for review September 9, 2022 07:08
@AlexTugarev AlexTugarev self-assigned this Sep 9, 2022
@AlexTugarev
Copy link
Member

AlexTugarev commented Sep 9, 2022 •
edited by werft-gitpod-dev-com bot
Loading

@geropl, please make me admin for this preview env 🙏🏻

@geropl
Copy link
Member Author

geropl commented Sep 9, 2022

@AlexTugarev done

@AlexTugarev AlexTugarev changed the title Show BillingMode on Team-/UserDetails pages [Admin] Show BillingMode on Team-/UserDetails pages Sep 9, 2022
AlexTugarev
AlexTugarev approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR works as advertised! Nice!

Screen Shot 2022-09-09 at 09 50 13

One thing I just noticed. Once you switched to UB on the team level, your billing mode switches accordingly, but when you cancel on stripe, the billing mode remains usage-based. Is that OK?

@roboquat roboquat merged commit c44b318 into main Sep 9, 2022
@roboquat roboquat deleted the gpl/12674-bm branch September 9, 2022 07:53
@AlexTugarev
Copy link
Member

@geropl, any Idea about #12770 (review)? Is this behavior expected?

@geropl
Copy link
Member Author

geropl commented Sep 9, 2022 •
edited
Loading

Is this behavior expected?

@AlexTugarev Yes. It's mainly controlled by the Feature Flag (which in dev is based on Team Membership). And it is only blocked by Personal Chargebee subscritions, which you did not set up: code, tests

@geropl geropl mentioned this pull request Sep 9, 2022
Closed
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Sep 9, 2022
@roboquat roboquat added the deployed Change is completely running in production label Sep 9, 2022
@geropl geropl mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

Assignees

@AlexTugarev AlexTugarev

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geropl @AlexTugarev @roboquat