Skip to content

[installer-tests] Add SCM authentication for integration tests #12772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

nandajavarma
Copy link
Contributor

@nandajavarma nandajavarma commented Sep 8, 2022

Description

This PR integrates the SCM authentication when running integration tests. The changes included here are the follows:

  • Using the GITHUB_SCM_OAUTH env var to provide the secret in core-dev cluster that stores the github token for github app
  • The secret will be appended with the callBackURL. This URL would point to an nginx server we have setup that will redirect to the correct subdomian specified using state query parameter
  • The above changes are added only when integration tests are run, otherwise we expect the users to have the opportunity to connect to their preferred SCM
  • The PR also changes one of the existing annotation skipTests to runTests. This is mostly because, we don't want the test running a default behavior, but an explicitly specified one.
  • The PR also updates the slack alert channel to be the corresponding team channels since potentially the fix in this PR should make the integration tests work.

Related Issue(s)

Fixes #12870

How to test

You can run the command:

werft run github -j .werft/k3s-installer-tests.yaml -a runTests=true

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@nandajavarma
Copy link
Contributor Author

nandajavarma commented Sep 13, 2022

/werft run with-sh-preview

👍 started the job as gitpod-build-nvn-githib-scm.4
(with .werft/ from main)

@nandajavarma
Copy link
Contributor Author

Fixed merge conflicts

Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

One question, but happy for this to be merged as-is

@nandajavarma
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit cc3033a into main Sep 26, 2022
@roboquat roboquat deleted the nvn/githib-scm branch September 26, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/L team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[installer-tests] Fix the Github SCM Authentication issue
3 participants