-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[installer-tests] Add SCM authentication for integration tests #12772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af2c565
to
e7d05ba
Compare
Contributor
Author
/werft run with-sh-preview 👍 started the job as gitpod-build-nvn-githib-scm.4 |
d07e237
to
307b3f6
Compare
d471e0e
to
d7f4f32
Compare
d7f4f32
to
6867050
Compare
10e9cc0
to
d532919
Compare
97e4594
to
8682c04
Compare
Fixed merge conflicts |
8682c04
to
1e025bc
Compare
1e025bc
to
680d9a7
Compare
mrsimonemms
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
One question, but happy for this to be merged as-is
Co-authored-by: Simon Emms <[email protected]>
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the SCM authentication when running integration tests. The changes included here are the follows:
GITHUB_SCM_OAUTH
env var to provide the secret in core-dev cluster that stores the github token for github appcallBackURL
. This URL would point to an nginx server we have setup that will redirect to the correct subdomian specified usingstate
query parameterskipTests
torunTests
. This is mostly because, we don't want the test running a default behavior, but an explicitly specified one.Related Issue(s)
Fixes #12870
How to test
You can run the command:
Release Notes
Documentation
Werft options: