[usage] Fix negative credits #12773
Merged
[usage] Fix negative credits #12773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
commented
Sep 8, 2022
|
|
||
| if i.StoppingTime.IsSet() { | ||
| if i.StoppingTime.Time().Before(maxStopTime) { |
There was a problem hiding this comment.
This was really the problem. If we wanted to retain the logic, we'd have needed to do
if i.StoppingTime.Time().After(maxStopTime) {
easyCZ
force-pushed
the
mp/usage-fix-negative-credits
branch
from
3e4a7e8 to
fe7c9d6
Compare
svenefftinge
approved these changes
Sep 8, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes negative credits.
Related Issue(s)
Fixes #
How to test
Unit tests
Release Notes
Documentation
Werft options: