Skip to content

Add ide-service server #12815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 14, 2022
Merged

Add ide-service server #12815

merged 5 commits into from
Sep 14, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Sep 9, 2022

Description

Add ide-service to resolve all IDE related things. First implement to bring

  • Make ide-service a component and deploy
  • Resolve image digest
  • Resolve nightly/latest tag of image
  • Verify config content
  • API to get config content (string)

Related Issue(s)

Relates #9189

How to test

  • Open this PR with Gitpod
  • Exec commands below to start a test service
cd components/ide-service
go run main.go run --config ./example-config.json
  • Exec test command to get parsed ide content
go run main.go test | jq
  • latestImage should not contain nightly or latest tag, should be resolved

ide-service in prev env

  • Open this PR with Gitpod
  • Wait until preview env installed
  • Exec commands below
# exec sh
kubectl exec -it ide-service<press_tab_to_get> -c ide-service sh

# run test cmd
./app/ide-service test --config /config/config.json
  • Output should be correct and align to server ide config response

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@mustard-mh mustard-mh changed the title Hw/ide service Add ide-service server Sep 9, 2022
@mustard-mh mustard-mh requested a review from iQQBot September 9, 2022 11:11
@mustard-mh mustard-mh marked this pull request as ready for review September 9, 2022 11:11
@mustard-mh mustard-mh requested review from a team September 9, 2022 11:11
@github-actions github-actions bot added team: IDE team: delivery Issue belongs to the self-hosted team labels Sep 9, 2022
@mustard-mh
Copy link
Contributor Author

mustard-mh commented Sep 9, 2022

@iQQBot Could you help review this PR 🙏

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 , I left some comment

We need to add ide-server in here, so that installer can known this component need render

ide_metrics.Objects,
ide_proxy.Objects,

And we need to add ide-service to CODEOWNER file

and werft build failed, otherwise code LGTM 🎉

/hold

@mustard-mh mustard-mh requested a review from a team September 9, 2022 17:04
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 9, 2022
@mustard-mh
Copy link
Contributor Author

mustard-mh commented Sep 9, 2022

Force pushed to [1]

  • Add CODEOWNERS
  • Remove ide-service-api typescript-grpcweb
  • Fix scheduleUpdate not called
  • Add installer component to render

Update:

  • Rebased to main to fix werft build error
  • Add ide-config from server/ide configmap

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-ide-service.15 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh mustard-mh force-pushed the hw/ide-service branch 5 times, most recently from 771c2e7 to fce1578 Compare September 9, 2022 18:43
@mustard-mh mustard-mh marked this pull request as draft September 9, 2022 19:10
@mustard-mh mustard-mh force-pushed the hw/ide-service branch 2 times, most recently from 145e529 to 7a393b6 Compare September 9, 2022 19:13
@mustard-mh mustard-mh marked this pull request as ready for review September 9, 2022 19:33
@mustard-mh
Copy link
Contributor Author

/unhold

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-ide-service.30 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat merged commit 951b20e into main Sep 14, 2022
@roboquat roboquat deleted the hw/ide-service branch September 14, 2022 07:50
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production labels Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production release-note-none size/XXL team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants