-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add ide-service server #12815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ide-service server #12815
Conversation
072851a
to
6dd3bdd
Compare
@iQQBot Could you help review this PR 🙏 |
6dd3bdd
to
0807637
Compare
0807637
to
fcb2893
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍 , I left some comment
We need to add ide-server
in here, so that installer can known this component need render
ide_metrics.Objects, | |
ide_proxy.Objects, |
And we need to add ide-service
to CODEOWNER file
and werft build failed, otherwise code LGTM 🎉
/hold
fcb2893
to
66c619c
Compare
Force pushed to [1]
Update:
|
started the job as gitpod-build-hw-ide-service.15 because the annotations in the pull request description changed |
771c2e7
to
fce1578
Compare
145e529
to
7a393b6
Compare
7a393b6
to
cf43f6e
Compare
c0ab491
to
888be5c
Compare
Co-authored-by: Simon Emms <[email protected]>
888be5c
to
410569b
Compare
/unhold |
started the job as gitpod-build-hw-ide-service.30 because the annotations in the pull request description changed |
Description
Add ide-service to resolve all IDE related things. First implement to bring
ide-service
a component and deployRelated Issue(s)
Relates #9189
How to test
latestImage
should not containnightly
orlatest
tag, should be resolvedide-service in prev env
Release Notes
Documentation
Werft options: