Skip to content

Adds vscode auth callback route #12844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

Adds vscode auth callback route #12844

merged 1 commit into from
Sep 12, 2022

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Sep 9, 2022 •
edited
Loading

Description

Adds vscode auth callback route

Related Issue(s)

Fixes #12660

How to test

  1. Open a workspace and install this test extension gitpod-foo-0.0.58.zip
  2. Update settings.json with "gitpod.host": "https://jp-test-9.preview.gitpod-dev.com/"
  3. Run Test FOO sign in command
  4. Check the callback page opens sucessfully, it says You can close this page now
  5. On vscode tab login will fail, that's expected
  6. Not required: If you want login to succeed, then go to this branch and change the redirect url to match your workspace, pointer [1], wait for build, yeah that sucks 🤦
  7. Check you are logged in
    image

Release Notes

NONE

Werft options:

  • /werft with-preview

@jeanp413
Copy link
Member Author

jeanp413 commented Sep 9, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jp-vscode-callback.4
(with .werft/ from main)

@jeanp413
Copy link
Member Author

jeanp413 commented Sep 9, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-jp-vscode-callback.5
(with .werft/ from main)

@jeanp413 jeanp413 marked this pull request as ready for review September 9, 2022 20:33
@jeanp413 jeanp413 requested review from a team September 9, 2022 20:33
@github-actions github-actions bot added team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Sep 9, 2022
@jeanp413 jeanp413 changed the title Adds vscode auth callback Adds vscode auth callback route Sep 9, 2022
@akosyakov
Copy link
Member

@jeanp413 is it backward compatible for workspaces which would be already running during ws deployment or later rollback?

@akosyakov
Copy link
Member

akosyakov commented Sep 12, 2022 •
edited
Loading

@mustard-mh @iQQBot Could you have a look please at changes to ws-proxy?

akosyakov
akosyakov approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

/hold

@jeanp413 jeanp413 force-pushed the jp/vscode-callback branch 2 times, most recently from 7df3fa8 to 78598f5 Compare September 12, 2022 16:31
@kylos101
Copy link
Contributor

is it backward compatible for workspaces which would be already running during ws deployment or later rollback?

Good question, @akosyakov!

@jeanp413 for you to test this, I think in the preview environment, you'll need to replace the version of ws-proxy with what we have running in production, and then do your functional test again. Depending on the result, we may need to coordinate a patch of ws-proxy code and/or config in workspace-cluster.

To test:

# assuming your kubectx is for a preview environment

# get a yaml file containing the versions for the build asset being in used for the workspace-cluster deployment as of Sept 12
docker run --rm eu.gcr.io/gitpod-core-dev/build/versions:main.4550 cat /versions.yaml > versions.yaml

# replace ws-proxy in your preview environment
kubectl set image deployment ws-proxy ws-proxy=eu.gcr.io/gitpod-core-dev/build/ws-proxy:$(yq e '.components.wsProxy.version' versions.yaml)

# run your functional test for this PR

@jeanp413
Copy link
Member Author

jeanp413 commented Sep 12, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jp-vscode-callback.10
(with .werft/ from main)

@jeanp413
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 350404f into main Sep 12, 2022
@roboquat roboquat deleted the jp/vscode-callback branch September 12, 2022 18:25
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production labels Sep 13, 2022
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

@andrew-farries andrew-farries andrew-farries approved these changes

@sagor999 sagor999 sagor999 approved these changes

@iQQBot iQQBot Awaiting requested review from iQQBot

@mustard-mh mustard-mh Awaiting requested review from mustard-mh

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to get OAuth-like flow to callback VS Code in browser
6 participants
@jeanp413 @akosyakov @kylos101 @andrew-farries @sagor999 @roboquat