Skip to content

[content-service] chown after prebuild git ops when using pvc #12896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented Sep 12, 2022

Description

When creating workspace that uses PVC from prebuild that doesn't, we need to ensure that we will do chown.
That is because when supervisor runs executor.Execute it runs with root:root, so any git op will mess up permissions.

Related Issue(s)

Fixes #12420

How to test

Enable PVC feature
Open workspace from prebuild that was created without PVC.

Release Notes

none

Documentation

Werft options:

  • /werft with-preview

@sagor999 sagor999 changed the title wip [content-service] chown after prebuild git ops when using pvc Sep 13, 2022
@sagor999 sagor999 marked this pull request as ready for review September 13, 2022 02:03
@sagor999 sagor999 requested a review from a team September 13, 2022 02:03
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pavel-gitfix.9 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Sep 13, 2022
@jenting
Copy link
Contributor

jenting commented Sep 13, 2022

/werft run with-preview

👍 started the job as gitpod-build-pavel-gitfix.10
(with .werft/ from main)

Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 78470a2 into main Sep 13, 2022
@roboquat roboquat deleted the pavel/gitfix branch September 13, 2022 02:49
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PVC] the files and folders under .git/ permission is incorrect
3 participants