test: Put logging of workspace starts and stops #12901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run with-preview 👍 started the job as gitpod-build-to-refactor-stopws.1 |
|
/werft run 👍 started the job as gitpod-build-to-refactor-stopws.2 |
jenting
reviewed
Sep 13, 2022
| stopWS(true) | ||
| }) | ||
|
|
||
| defer func() { |
There was a problem hiding this comment.
Any reason why we change to use defer?
There was a problem hiding this comment.
defer is called before cleanup because stopws depends on api and context and should be called before api.Done. However, I will make the change later so that stopws is not dependent on them.
| @@ -116,12 +116,12 @@ func TestBackup(t *testing.T) { | |||
| if err != nil { | |||
| t.Fatal(err) | |||
| } | |||
| t.Cleanup(func() { | |||
| defer func() { | |||
There was a problem hiding this comment.
Any reason why we change to use defer?
jenting
reviewed
Sep 14, 2022
utam0k
force-pushed
the
to/refactor-stopws
branch
from
617423b to
e04abe5
Compare
|
@jenting PTAL |
jenting
reviewed
Sep 14, 2022
utam0k
force-pushed
the
to/refactor-stopws
branch
from
e04abe5 to
21f2d4c
Compare
jenting
approved these changes
Sep 14, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test: Put logging of workspace starts and stops
Related Issue(s)
Relates #12248
How to test
Run the test and get logs
Release Notes
Documentation
Werft options: