[prebuild] Log 'not using incremental prebuild' as debug #12916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: webapp
jankeromnes
approved these changes
Sep 13, 2022
|
We're not. We ship everything INFO and more severe to GCP |
|
And to me it makes sense to ship INFO. I think we could make better use of fields and context to largely end up with ~1 message per request in logs. We could achieve this by enabling logging every request on a middleware level, attach request ID and other properties from the context that we populate as we process a request and then log it on the middleware as we respond. It would provide an easy extension for request tracing in logs. We do have honecomb tracing but that's sampled. What we'd get here is the ability to respond with a Request ID and ask users to quote it back to us for support cases. |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The log accounts for about 40% (~10k) of log messages in a given hour. Given we've added it in 45f13cf (in April) and haven't really used the log for anything, it feels safe to downgrade. We can always change or add metrics for this if we need it.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: