Skip to content

[installer]: make the installer config file consistent #12920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

mrsimonemms
Copy link
Contributor

Description

This uses the envvar GITPOD_INSTALLER_CONFIG throughout and defaults to ${PWD}/gitpod.config.yaml. Used the more established envvar to avoid breaking any existing scripts that depend on this in the wild

How to test

Release Notes

[installer]: make the installer config file consistent

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms mrsimonemms marked this pull request as ready for review September 13, 2022 13:44
@mrsimonemms mrsimonemms requested a review from a team September 13, 2022 13:44
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 13, 2022
@mrsimonemms
Copy link
Contributor Author

/hold found one extra

This uses the envvar GITPOD_INSTALLER_CONFIG throughout and defaults
to `${PWD}/gitpod.config.yaml`
@mrsimonemms mrsimonemms force-pushed the sje/installer-config-file branch from e972d1c to f3da9b1 Compare September 13, 2022 13:54
@roboquat roboquat merged commit f514e30 into main Sep 13, 2022
@roboquat roboquat deleted the sje/installer-config-file branch September 13, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants