[stripe] Use AttributionID metadata when querying for customers #12921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/server-stripe-attribution-id
branch
from
27adefa to
00ad1c5
Compare
|
started the job as gitpod-build-mp-server-stripe-attribution-id.1 because the annotations in the pull request description changed |
easyCZ
changed the title
|
/werft run with-preview with-billing 👍 started the job as gitpod-build-mp-server-stripe-attribution-id.2 |
|
/werft run with-preview with-payment 👍 started the job as gitpod-build-mp-server-stripe-attribution-id.3 |
svenefftinge
approved these changes
Sep 13, 2022
| @@ -34,11 +36,15 @@ export class StripeService { | |||
| } | |||
|
|
|||
| async findCustomerByUserId(userId: string): Promise<Stripe.Customer | undefined> { | |||
| return this.findCustomerByQuery(`metadata['userId']:'${userId}'`); | |||
| return this.findCustomerByQuery( | |||
| `metadata['${ATTRIBUTION_ID_METADATA_KEY}']:'${AttributionId.render({ kind: "user", userId })}'`, | |||
There was a problem hiding this comment.
do you plan to manually update existing customers?
There was a problem hiding this comment.
They've already been updated. The previous PR changed the subscription queries to set the attribution ID alongside the previous team/user id, this now removes old I'd usage
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
attributionIdwhen querying for customers, instead team/user IdRelated Issue(s)
Fixes #
How to test
attributionId:...setRelease Notes
Documentation
Werft options: