test: Handle errors relate network in port-fowarding

[utam0k]

Description

test: Handle errors relate network in port-fowarding

Related Issue(s)

Relates #12248

How to test

Run the test

Release Notes

NONE

Documentation

Werft options:

• /werft with-preview

[jenting]

Thanks for the PR.
But from my testing recent days, I did not encounter the port-forward error.
So I think should we need to enhance the port-forward error again because you have enhanced it in the last PR already.

[jenting]

Should we check if the error is errorDialingBackendEOF, then retry?

[utam0k]

Yes.

[jenting]

I haven't seen you change this. 🤔

[utam0k]

@jenting
Sorry, I may misunderstand. Can I ask you to rephrase?

[jenting]

Never mind, my thought was the same logic

        if err.Error() == errorDialingBackendEOF && count < connectFailureMaxTries {
		return true
	}
        return false

[utam0k]

Thanks for the PR.
But from my testing recent days, I did not encounter the port-forward error.
So I think should we need to enhance the port-forward error again because you have enhanced it in the last PR already.

Have you ran all tests from werft?

[jenting]

Thanks for the PR.
But from my testing recent days, I did not encounter the port-forward error.
So I think should we need to enhance the port-forward error again because you have enhanced it in the last PR already.

Have you ran all tests from werft?

Yes, about five times.

[utam0k]

Thanks for the PR.
But from my testing recent days, I did not encounter the port-forward error.
So I think should we need to enhance the port-forward error again because you have enhanced it in the last PR already.

Have you ran all tests from werft?

Yes, about five times.

@jenting
This appears to be an error in port-forwarding. May I ask you to tell me what your job is?
https://werft.gitpod-dev.com/job/gitpod-workspace-run-integration-tests-main.118/raw

[jenting]

Thanks for the PR.
But from my testing recent days, I did not encounter the port-forward error.
So I think should we need to enhance the port-forward error again because you have enhanced it in the last PR already.

Have you ran all tests from werft?

Yes, about five times.

@jenting This appears to be an error in port-forwarding. May I ask you to tell me what your job is? https://werft.gitpod-dev.com/job/gitpod-workspace-run-integration-tests-main.118/raw

🤔 I might be wrong. I did not check the lastest workspace integration tests result.

[utam0k]

@jenting At least, around these codes often get failed when I run it from my local

gitpod/test/pkg/integration/integration.go

Lines 95 to 97 in ded3a97

	if err != nil {
	return nil, nil, nil, fmt.Errorf("Could not run exec operation: %v", err)
	}

--- FAIL: TestCreateBucket (5.78s)
    --- FAIL: TestCreateBucket/DaemonAgent.CreateBucket (5.78s)
        --- FAIL: TestCreateBucket/DaemonAgent.CreateBucket/it_should_create_a_bucket (5.78s)
            storage_test.go:32: Could not run copy operation: error dialing backend: EOF

[utam0k]

@jenting Thanks for your review. PTAL