test: Enhanced running in unstable environments #12966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can get successful in four rows except for failing to prepare preview env. |
jenting
approved these changes
Sep 15, 2022
| @@ -126,30 +118,47 @@ func runContextTests(t *testing.T, tests []ContextTest) { | |||
| {Name: "pvc", FF: "persistent_volume_claim"}, | |||
| } | |||
|
|
|||
| for _, ff := range ffs { | |||
| func() { | |||
| @@ -109,7 +138,7 @@ func TestPrebuildWorkspaceTaskFail(t *testing.T) { | |||
| t.Fatalf("cannot start workspace: %q", err) | |||
| } | |||
|
|
|||
| t.Cleanup(func() { | |||
| defer func() { | |||
There was a problem hiding this comment.
Perhaps you could summarize when to use defer and when to use t.Cleanup.
loujaybee
added
team: no-team
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a failed of this job
Related Issue(s)
Relates #12248
How to test
Run the test
Release Notes
Documentation
Werft options: