Add .gitattributes to mark installer golden files as generated #12990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
approved these changes
Sep 15, 2022
|
Currently, we don't have a deterministic pattern to use to mark all generated code (from grpc for example). in theory, we could take I think a reasonable change we could make is to move generated code into a |
roboquat
added
deployed: webapp
|
I've found a pattern that more-less works - #13078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will automatically collapse the
*.goldenfiles in PRs and mark them as auto-generated.Because it's causing PRs to be messy with changes which are auto-generated
See docs
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: