Move tsc to validate changes. Run validations in parallel #12998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mads-hartmann
commented
Sep 15, 2022
| @@ -45,7 +45,8 @@ export async function buildAndPublish(werft: Werft, jobConfig: JobConfig) { | |||
| if (publishRelease) { | |||
| exec(`gcloud auth activate-service-account --key-file "/mnt/secrets/gcp-sa-release/service-account.json"`); | |||
| } | |||
| exec( | |||
|
|
|||
| await exec( | |||
There was a problem hiding this comment.
This is the change I'm talking about in the PR description. Without this traces break.
1 task
ArthurSens
reviewed
Sep 15, 2022
| branchNameCheck(werft, config); | ||
| preCommitCheck(werft); | ||
| await Promise.all([branchNameCheck(werft, config), preCommitCheck(werft), typecheckWerftJobs(werft)]); |
There was a problem hiding this comment.
That's really nice, I bet there are more places that we could do the same thing 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To declutter the Werft phases for the build job I've moved the
tsccheck to the "Validating changes" phase. I also changed the implementation oftypecheckWerftJobsandpreCommitCheckso they are properly async, which makes it possible to run them in parallel (achieved throughPromise.all)I also had to make the actual build execution use
awaitand addexec(.., { async: true })as traces otherwise broke. I'm not a 100% certain why this is needed - my hunch is that by running the build in a promise we're allowing other code to temporarily execute on the event loop which takes care of some trace management - as the change is harmless I'm okay keeping it in this PR and then we can investigate why the traces breaks without it some other time.Related Issue(s)
No issue, just noticed this when working on other things
How to test
Here's a screenshot before/after that shows the slice has been moved to the validating phase (resulting in less clutter IMO)
And here's a screenshot of the trace before/after that shows that the slices are now running in parallel (not that there is a huge speed increase as the precommit hook takes much longer than tsc --noEmit, but nonetheless)
Release Notes
Documentation
N/A
Werft options: